Add ManagedServerSecurityAlertPolicy and ManagedDatabaseSecurityAlert… by talhers · Pull Request #4521 · Azure/azure-rest-api-specs

talhers · 2018-11-20T10:09:51Z

…Policies

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

…Policies

openapi-portal-comment · 2018-11-20T10:09:53Z

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

AutorestCI · 2018-11-20T10:10:38Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3769

AutorestCI · 2018-11-20T10:10:40Z

Automation for azure-sdk-for-js

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-js#570

AutorestCI · 2018-11-20T10:10:43Z

Automation for azure-sdk-for-node

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-node#4181

AutorestCI · 2018-11-20T10:11:06Z

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#1871

AutorestCI · 2018-11-20T10:13:11Z

Automation for azure-sdk-for-java

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-java#2138

AutorestCI · 2018-11-20T10:14:37Z

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

talhers · 2018-11-20T10:15:29Z

@yaakoviyun @yoavfr

yaakoviyun · 2018-11-20T10:21:05Z

@ayeletshpigelman

azuresdkci · 2018-11-20T10:26:26Z

Can one of the admins verify this patch?

praries880 · 2018-11-20T19:27:05Z

@talhers Have the new APIs been through an API review?

talhers · 2018-11-21T07:00:26Z

@talhers Have the new APIs been through an API review?

These APIs are similar to the regular server and database APIs:

https://github.com/Azure/azure-rest-api-specs/blob/master/specification/sql/resource-manager/Microsoft.Sql/stable/2014-04-01/databaseSecurityAlertPolicies.json

https://github.com/Azure/azure-rest-api-specs/blob/master/specification/sql/resource-manager/Microsoft.Sql/preview/2017-03-01-preview/serverSecurityAlertPolicies.json

The difference is that they apply to managed instance and managed database (except for that they are identical)

ravbhatnagar

@talhers - some comments. please take a look.

ravbhatnagar · 2018-12-12T08:22:46Z

...e-manager/Microsoft.Sql/preview/2017-03-01-preview/ManagedDatabaseSecurityAlertPolicies.json

+    "application/json"
+  ],
+  "paths": {
+    "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Sql/managedInstances/{managedInstanceName}/databases/{databaseName}/securityAlertPolicies/{securityAlertPolicyName}": {


LIST api to get all securityAlertPolicies for a database missing.

We will open a work item for this

ravbhatnagar · 2018-12-12T08:23:39Z

...e-manager/Microsoft.Sql/preview/2017-03-01-preview/ManagedDatabaseSecurityAlertPolicies.json

+  "produces": [
+    "application/json"
+  ],
+  "paths": {


Also, it may be helpful to have a PATCH APi for this. For example to update the state of a policy, doing a PUT may be an overkill. PATCH will be much more convenient.

After thinking about it we don't think that a patch is needed in our customer scenarios

ravbhatnagar · 2018-12-12T08:24:46Z

...e-manager/Microsoft.Sql/preview/2017-03-01-preview/ManagedDatabaseSecurityAlertPolicies.json

+          "description": "Specifies the blob storage endpoint (e.g. https://MyAccount.blob.core.windows.net). This blob storage will hold all Threat Detection audit logs.",
+          "type": "string"
+        },
+        "storageAccountAccessKey": {


should not be returned in the response of a Get or PUT. A better model may be to fetch it on behalf of the user using s2S auth.

We will open a work item for this

ravbhatnagar · 2018-12-12T08:25:40Z

...ource-manager/Microsoft.Sql/preview/2017-03-01-preview/ManagedServerSecurityAlertPolicy.json

+  "produces": [
+    "application/json"
+  ],
+  "paths": {


same comments as above.

We will open a work item for this

talhers · 2018-12-12T13:43:53Z

We will open work items on the comments above and fix them in our next API version.
Can you take another look and merge the PR if everything is fine? This is a blocker for cmdlet implementation.
Thanks!

ravbhatnagar · 2018-12-13T20:42:43Z

Couple of pending issues Tracked here #4910
Signing off from ARM side.

ravbhatnagar · 2018-12-13T20:42:53Z

#4910

Azure#4521) * Add ManagedServerSecurityAlertPolicy and ManagedDatabaseSecurityAlertPolicies * fix incompatible values in swagger * Fix ManagedDatabaseSecurityAlertCreateMin example file

Add ManagedServerSecurityAlertPolicy and ManagedDatabaseSecurityAlert…

aa1c72b

…Policies

azuresdkci assigned praries880 Nov 20, 2018

azuresdkci requested a review from praries880 November 20, 2018 10:32

fix incompatible values in swagger

6969762

praries880 added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Nov 20, 2018

praries880 added the APIStewardshipBoard-ReviewRequested This should be reviewed by the Azure API Stewardship team in partnership with the service team. label Nov 20, 2018

KrisBash added ARMChangesRequested and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Nov 21, 2018

Fix ManagedDatabaseSecurityAlertCreateMin example file

9d6a28b

KrisBash added the ARMChangesRequested label Dec 7, 2018

ravbhatnagar reviewed Dec 12, 2018

View reviewed changes

ravbhatnagar removed the ARMReviewInProgress label Dec 12, 2018

ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Dec 13, 2018

praries880 approved these changes Dec 13, 2018

View reviewed changes

praries880 merged commit 2f6d951 into Azure:master Dec 13, 2018

AutorestCI mentioned this pull request Dec 13, 2018

[AutoPR sql/resource-manager] Add ManagedServerSecurityAlertPolicy and ManagedDatabaseSecurityAlert… Azure/azure-sdk-for-java#2787

Merged

talhers mentioned this pull request Dec 16, 2018

Add SDK for Security Alerts on Managed Instance Azure/azure-sdk-for-net#5093

Merged

9 tasks

Conversation

talhers commented Nov 20, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Latest improvements:

Contribution checklist:

Uh oh!

openapi-portal-comment bot commented Nov 20, 2018

Uh oh!

AutorestCI commented Nov 20, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

AutorestCI commented Nov 20, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-js

Uh oh!

AutorestCI commented Nov 20, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-node

Uh oh!

AutorestCI commented Nov 20, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-ruby

Uh oh!

AutorestCI commented Nov 20, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-java

Uh oh!

AutorestCI commented Nov 20, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

talhers commented Nov 20, 2018

Uh oh!

yaakoviyun commented Nov 20, 2018

Uh oh!

azuresdkci commented Nov 20, 2018

Uh oh!

praries880 commented Nov 20, 2018

Uh oh!

talhers commented Nov 21, 2018

Uh oh!

ravbhatnagar left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

talhers commented Dec 12, 2018

Uh oh!

ravbhatnagar commented Dec 13, 2018

Uh oh!

ravbhatnagar commented Dec 13, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

talhers commented Nov 20, 2018 •

edited

Loading

AutorestCI commented Nov 20, 2018 •

edited

Loading

AutorestCI commented Nov 20, 2018 •

edited

Loading

AutorestCI commented Nov 20, 2018 •

edited

Loading

AutorestCI commented Nov 20, 2018 •

edited

Loading

AutorestCI commented Nov 20, 2018 •

edited

Loading

AutorestCI commented Nov 20, 2018 •

edited

Loading